Effects: Merge 2 articles on queues #633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58ee88d to
eb8623b
Compare
Member
There was a problem hiding this comment.
We should either call dequeue in this function, or take a next parameter and call it so that something "after" the queue would run and it doesn't get locked up.
Member
Author
There was a problem hiding this comment.
That was what I was trying to explain people with the text further in the article. But you're right, maybe it makes sense to directly show people a good example.
Member
|
Looking good |
e8d88f3 to
4648c9b
Compare
Member
Author
|
Did a commit with some fixes. What do you think, @gnarf? |
Member
There was a problem hiding this comment.
This is a callback, "in the animation" seems....
Member
|
LGTM |
Member
Author
|
@gnarf Thanks for being that quick reviewing it. I addressed that last little thing. Gonna give people some more time to throw in feedback, and merging tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we had 2 articles on queues overlapping each other, those need to be merged together (#77). After all I ended up rewriting/clarifying the whole article.
Would fix #77.